Support for Delivered Public Key Certificates #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandelsoft
force-pushed
the
signing
branch
3 times, most recently
from
7c4be37 to
a057e4d
Compare
mandelsoft
force-pushed
the
signing
branch
2 times, most recently
from
898fac5 to
e914fb3
Compare
fabianburth
requested changes
Dec 5, 2023
pkg/signing/signutils/certs.go
Outdated
|
|
||
| type Usages []interface{} | ||
|
|
||
| // Specification specified the xontext for the certificate creation. |
There was a problem hiding this comment.
typos
Suggested change
| // Specification specified the xontext for the certificate creation. | |
| // Specification specifies the context for the certificate creation. |
pkg/signing/signutils/certs.go
Outdated
|
|
||
| PublicKey GenericPublicKey | ||
|
|
||
| // CAPrivateKey is the provate key used for signing. |
There was a problem hiding this comment.
typo
Suggested change
| // CAPrivateKey is the provate key used for signing. | |
| // CAPrivateKey is the private key used for signing. |
mandelsoft
force-pushed
the
signing
branch
2 times, most recently
from
1c53a98 to
37e0aaa
Compare
fabianburth
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for Public Key certificates has been added, the certificates are published together with the component version
as part of the signature.
If a signature validation is done a public key can be omitted now, if the signature contains a valid
certificate chain for a public key certificate. Additionally to the chain validation the Issuer (Distinguished Name) is checked
for the the public key certificate.
With a dedicated option (--tsa) a signed timestamp (TSA) is stored along with the signature, which is used (if set)
to specify the verification time for the certificate chain. A signature is only accepted if the certificate chai can be verified
for the signing time and the timestamp can be verified.
The commands have been extended to
Internally the the issuer has been migrated from a string to a pkix.Name.
The DN match checks for the existence of given attributes in the public key certificate.
The config has been extended to define expected issuers for signature names and a TSA server URL.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: